Re: [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors

On Fri, Jul 12, 2024 at 12:00:15PM +0200, Matthieu Baerts (NGI0) wrote:

It looks like we missed these two errors recently:

• SC2068: Double quote array expansions to avoid re-splitting elements.
• SC2145: Argument mixes string and array. Use * or separate argument.

Two simple fixes, it is not supposed to change the behaviour as the variable names should not have any spaces in their names. Still, better to fix them to easily spot new issues.

Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers") Signed-off-by: Matthieu Baerts (NGI0) matttbe@kernel.org

---

Notes:

• The mentioned commit is currently only in 'net-next', not in 'net'.

Reviewed-by: Simon Horman horms@kernel.org