Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

On 14.06.24 04:30, John Hubbard wrote:

Clean up and move some copy-pasted items into a new mseal_helpers.h.

1. The test macros can be made safer and simpler, by observing that they

are invariably called when about to return. This means that the macros do not need an intrusive label to goto; they can simply return.

2. PKEY* items. We cannot, unfortunately use pkey-helpers.h. The best we

can do is to factor out these few items into mseal_helpers.h.

3. These tests still need their own definition of u64, so also move that

to the header file.

Cc: Jeff Xu jeffxu@chromium.org Cc: David Hildenbrand david@redhat.com Signed-off-by: John Hubbard jhubbard@nvidia.com

---

Acked-by: David Hildenbrand david@redhat.com