On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino vincenzo.frascino@arm.com wrote:
diff --git a/arch/arm/include/asm/vdso/gettimeofday.h b/arch/arm/include/asm/vdso/gettimeofday.h new file mode 100644 index 000000000000..eeeb319840ba --- /dev/null +++ b/arch/arm/include/asm/vdso/gettimeofday.h @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/*
- Copyright (C) 2018 ARM Limited
- */
+#ifndef __ASM_VDSO_GETTIMEOFDAY_H +#define __ASM_VDSO_GETTIMEOFDAY_H
+#ifndef __ASSEMBLY__
+#include <asm/barrier.h> +#include <asm/cp15.h> +#include <asm/unistd.h> +#include <uapi/linux/time.h>
+#ifndef CONFIG_AEABI +#error This code depends on AEABI system call conventions +#endif
Instead of an #error here, I would use a Kconfig conditional and make it
'select HAVE_GENERIC_VDSO if AEABI'
diff --git a/arch/arm/vdso/vdso.lds.S b/arch/arm/vdso/vdso.lds.S index 89ca89f12d23..05581140fd12 100644 --- a/arch/arm/vdso/vdso.lds.S +++ b/arch/arm/vdso/vdso.lds.S @@ -82,6 +82,8 @@ VERSION global: __vdso_clock_gettime; __vdso_gettimeofday;
__vdso_clock_getres;__vdso_clock_gettime64; local: *; };
Why are you adding __vdso_clock_getres here? I would probably leave the addition of the new entry point(s) for a separate patch at the end, adding __vdso_clock_gettime64 to all 32-bit ABIs at once, since while that part is a trivial change, it's also user visible and deserves its own changelog text.
Arnd