Re: [PATCH 10/32] pid: use ns_common_init()

On Wed 10-09-25 16:36:55, Christian Brauner wrote:

Don't cargo-cult the same thing over and over.

Signed-off-by: Christian Brauner brauner@kernel.org

Looks good. Feel free to add:

Reviewed-by: Jan Kara jack@suse.cz

Honza

---

kernel/pid_namespace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index 7098ed44e717..20ce4052d1c5 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -102,17 +102,15 @@ static struct pid_namespace *create_pid_namespace(struct user_namespace *user_ns if (ns->pid_cachep == NULL) goto out_free_idr;

• err = ns_alloc_inum(&ns->ns);

• err = ns_common_init(&ns->ns, &pidns_operations, true); if (err) goto out_free_idr;

• ns->ns.ops = &pidns_operations;

ns->pid_max = PID_MAX_LIMIT; err = register_pidns_sysctls(ns); if (err) goto out_free_inum;

• refcount_set(&ns->ns.count, 1); ns->level = level; ns->parent = get_pid_ns(parent_pid_ns); ns->user_ns = get_user_ns(user_ns);

-- 2.47.3