Re: [PATCH v13 08/24] selftests/vm: fix the wrong assert in pkey_disable_set()

On 06/13/2018 05:44 PM, Ram Pai wrote:

If the flag is 0, no bits will be set. Hence we cant expect the resulting bitmap to have a higher value than what it was earlier

...

if (flags)

• pkey_assert(read_pkey_reg() > orig_pkey_reg);
  

• pkey_assert(read_pkey_reg() >= orig_pkey_reg);
  

  dprintf1("END<---%s(%d, 0x%x)\n", __func__, pkey, flags);

}

This is the kind of thing where I'd love to hear the motivation and background. This "disable a key that was already disabled" operation obviously doesn't happen today. What motivated you to change it now? -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html