On 12/2/25 11:16 AM, Simon Horman wrote:
On Mon, Dec 01, 2025 at 02:48:48PM -0800, Chris Mason wrote:
On Mon, 1 Dec 2025 20:52:34 +0100 Jonas Gorski jonas.gorski@gmail.com wrote:
[ ... ]
I reproduced this false positive here, thanks for the explanation. This is an example of a class of review mistakes I've wanted to fix, so I used it to improve the prompts around NULL pointers that are protected via other checks.
I'll test this on some more commits and push it out.
Thanks for following-up on this Chris.
I guess everyone has their own opinion on AI. And, in a similar vein, many have opinions on the review-prompts. But, FTR, I've been impressed by the output I've seen, having used them for a few weeks now. And I look forward to that improving further.
Thanks, I really appreciate everyone being willing to experiment with the reviews (and huge thanks to Jakub for wiring this up). I'll try to stay on top of the false positives, but please also let me know if I'm missing classes of bugs.
I think Jonas's other_dp->user check is really at the limit of claude's ability to reason about the code in a generic way, and I'm still trying to get it to process this patch consistently.
If all else fails we can fix some of these with more networking specific knowledge, but I'm trying to avoid whack-a-mole.
-chris