On 15/12/2023 14:08, Mark Brown wrote:
On Fri, Dec 15, 2023 at 01:58:45PM +0000, Ryan Roberts wrote:
On 15/12/2023 13:54, Mark Brown wrote:
What I did for ftrace which had a similar situation was make a wrapper script which invokes the test runner, make the test runner a TEST_PROGS_EXTENDED so it's not run by the kselftest infrastructure automatically and make the wrapper a normal TEST_PROGS. Neither option is especially lovely.
Yeah that's a good idea... I'll wait and see if anyone shouts that this has broken something. If nothing is broken, I think it is better to just make TAP the default rather than adding yet another wrapper.
I think it depends a bit how ergonomic the non-TAP output is for interactive use - TAP isn't amazing for humans so if there's something that's nicer it probably makes sense to keep that as the default. For these tests I'm not sure it's particularly an issue.
I've kept all the existing "pretty" output and results summary as is, it just gets a hash in front of it when TAP is enabled.
so this:
----------------------- running ./hugepage-mmap ----------------------- Returned address is 0xffff89e00000 First hex is 0 First hex is 3020100 [PASS] SUMMARY: PASS=1 SKIP=0 FAIL=0
becomes this:
TAP version 13 # ----------------------- # running ./hugepage-mmap # ----------------------- # Returned address is 0xffff89e00000 # First hex is 0 # First hex is 3020100 # [PASS] ok 1 hugepage-mmap # SUMMARY: PASS=1 SKIP=0 FAIL=0 1..1
If you think the latter is ofensive, then I can do the wrapping as you suggest.