Re: [PATCH] kunit: fixes backtrace suppression test module description

On Sun, Mar 30, 2025 at 01:11:59PM +0800, David Gow wrote:

On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati acarmina@redhat.com wrote:

...

Adds module description to the backtrace suppression test

Fixes: ("19f3496") kunit: add test cases for backtrace warning suppression

Signed-off-by: Alessandro Carminati acarmina@redhat.com

The "Fixes" tag here should be immediately before the Signed-off-by line, without a newline. Also, ideally the format should be something like: Fixes: d03d078df162 ("kunit: add test cases for backtrace warning suppression")

Yeah. Everyone should configure the default hash length to 12.

git config set --global core.abbrev 12

I generate my fixes tags like so:

#!/bin/bash

git log -1 --format='Fixes: %h ("%s")' $*

regards, dan carpenter