Re: [PATCH v11 23/25] mm/gup: track FOLL_PIN pages

On 12/16/19 4:53 AM, Jan Kara wrote: ...

I'd move this still a bit higher - just after VM_BUG_ON_PAGE() and before if (flags & FOLL_TOUCH) test. Because touch_pmd() can update page tables and we don't won't that if we're going to fail the fault.

Done. I'll post a full v11 series shortly.

With this fixed, the patch looks good to me so you can then add:

Reviewed-by: Jan Kara jack@suse.cz

						Honza

btw, thanks for the thorough review of this critical patch (and for your patience with my mistakes). I really appreciate it, and this patchset would not have made it this far without your detailed help and explanations.

thanks,