Re: [PATCH net-next v2 4/4] selftests: hsr: Add test for VLAN

On 10/24/24 12:30, MD Danish Anwar wrote:

@@ -183,9 +232,21 @@ trap cleanup_all_ns EXIT setup_hsr_interfaces 0 do_complete_ping_test +# Run VLAN Test +if $vlan; then

• setup_vlan_interfaces
• hsr_vlan_ping

+fi

setup_ns ns1 ns2 ns3 setup_hsr_interfaces 1 do_complete_ping_test +# Run VLAN Test +if $vlan; then

• setup_vlan_interfaces
• hsr_vlan_ping

+fi

The new tests should be enabled by default. Indeed ideally the test script should be able to run successfully on kernel not supporting such feature; you could cope with that looking for the hsr exposed feature and skipping the vlan test when the relevant feature is not present.

Cheers,

Paolo