Re: [PATCH v2 04/24] selftests/resctrl: Remove mum_resctrlfs

On Fri, 21 Apr 2023, Reinette Chatre wrote:

...

-int remount_resctrlfs(bool mum_resctrlfs) +int mount_resctrlfs(void) {

• char mountpoint[256]; int ret;

• ret = find_resctrl_mount(mountpoint);
• if (ret)

• strcpy(mountpoint, RESCTRL_PATH);
  

• if (!ret && mum_resctrlfs && umount(mountpoint))

• ksft_print_msg("Fail: unmounting \"%s\"\n", mountpoint);
  

• if (!ret && !mum_resctrlfs)

• return 0;
  

• ret = find_resctrl_mount(NULL);
• if (!ret)

• return -1;
  

This seems to assume that resctrl is always unmounted. Should the main program thus start by unmounting resctrl before it runs any test in case it is mounted when user space starts the tests?

I thought that was the wanted functionality. I've now added a change to the series which does this umount before starting a tests.