Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer

On Sat, Jul 25, 2020 at 12:07:00PM +0200, Greg Kroah-Hartman wrote:

On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote:

...

The EFI platform firmware fallback would clobber any pre-allocated buffers. Instead, correctly refuse to reallocate when too small (as already done in the sysfs fallback), or perform allocation normally when needed.

Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firm ware_request_platform()")

"firmware_request_platform()" :)

Weird... I'm not sure where that mangling happened. Perhaps a bad cut/paste at 80 columns? Hmpf; thanks for catching. I've updated it on my end (I assume you fixed this manually, though?)

Thanks!