On Mon, Mar 04, 2024 at 03:36:20PM -0800, Jakub Kicinski wrote:
selftest harness uses various exit codes to signal test results. Avoid calling exit() directly, otherwise tests may get broken by harness refactoring (like the commit under Fixes). SKIP() will instruct the harness that the test shouldn't run, it used to not be the case, but that has been fixed. So just return, no need to exit.
Note that for hmm-tests this actually changes the result from pass to skip. Which seems fair, the test is skipped, after all.
Reviewed-by: Mark Brown broonie@kernel.org Tested-by: Mark Brown broonie@kernel.org
This fixes at least the pcmtest-driver suite.