On 10/14/22 05:21, Alistair Popple wrote:
Seems like this would fix both the SKIP in FIXTURE_SETUP and ASSERT in FIXTURE_TEARDOWN issues:
Yep, that fixed the infinite error loops for me, thanks.
...
Unlike hmm-tests though the above snippet reports correct pass/skip statistics with the teardown assertion removed. This is because there is also a bug in hmm-tests. Currently we have:
SKIP(exit(0), "DEVICE_COHERENT not available");
Which should really be:
SKIP(return, "DEVICE_COHERENT not available");
And with this on top, I got the skips due to DEVICE_COHERENT not available counted correctly.
Of course that results in an infinite loop due to the associated assertion failure during teardown which is still called despite the SKIP in setup. Not sure if this is why it was originally coded this way.
- Alistair
thanks, -- Shuah