Re: [PATCH v2 06/11] selftests/mm: fix two -Wformat-security warnings in uffd builds

On Fri, Jun 02, 2023 at 07:15:53PM -0700, John Hubbard wrote:

The uffd tests generate two compile time warnings from clang's -Wformat-security setting. These trigger at the call sites for uffd_test_start() and uffd_test_skip().

1. Fix the uffd_test_start() issue by removing the intermediate

test_name variable (thanks to David Hildenbrand for showing how to do this).

2. Fix the uffd_test_skip() issue by observing that there is no need for

a macro and a variable args approach, because all callers of uffd_test_skip() pass in a simple char* string, without any format specifiers. So just change uffd_test_skip() into a regular C function.

Cc: David Hildenbrand david@redhat.com Cc: Peter Xu peterx@redhat.com Signed-off-by: John Hubbard jhubbard@nvidia.com

Reviewed-by: Peter Xu peterx@redhat.com

Thanks,