On Tue, Aug 22, 2023 at 01:54:56AM +0000, Joel Fernandes (Google) wrote:
When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens.
Signed-off-by: Joel Fernandes (Google) joel@joelfernandes.org
tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1;
goto out;
goto clean_up_src;-- 2.42.0.rc1.204.g551eb34607-goog
Nice spot!
Reviewed-by: Lorenzo Stoakes lstoakes@gmail.com