On Thu, Dec 01, 2022 at 09:42:52PM +0100, Jaroslav Kysela wrote:
As for the generic tool, I would like to have an option to control all mechanisms:
- only default config
- only hw specific config
- default + hw specific configs (merged)
A new field in the pcm configuration may be added for this to build the per-device-stream configuration. If we merge those two configs, I think that only a field which will skip the default config is sufficient to cover all possibilities. The test names are a good identification, what was executed.
That's not quite what I implemented (see below...) but I think it's not too far off.
As Takashi already applied your set, I'll try to merge my code with yours and keep the added functionality.
I've just prepared a branch which I'm running through my tests now which just does a revert, applies your patch and then does most of what I said. I'll send it later assuming everything looks OK enough on my test farm (probably in ~1-2 hours). All this working together is great but one of us needs to move to a different timezone. :P I think we're *roughly* on the same page here, just some edges to iron out.
For the config merging/selection thing I think for the merge we could either add a section in the per-board config which overrides defaults or just go with what I did where we add the test list, as well as adding command line options to select only the per-board or only the per-system. Does any of that line up with what you were thinking?
The following changes since commit 7d721baea138696d5a6746fb5bce0a510a91bd65:
kselftest/alsa: Add more coverage of sample rates and channel counts (2022-12-01 20:02:14 +0100)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git alsa-pcm-test-hacks
for you to fetch changes up to 9e96c58e581313bd639fd51f37c8e831d7b4a05c:
kselftest/alsa: pcm - Add more coverage by default (2022-12-01 22:46:30 +0000)
---------------------------------------------------------------- Jaroslav Kysela (1): kselftest/alsa: pcm - move more configuration to configuration files
Mark Brown (6): kselftest/alsa: pcm - Drop recent coverage improvement changes kselftest/alsa: pcm - Always run the default set of tests kselftest/alsa: pcm - skip tests when we fail to set params kselftest/alsa: pcm - Support optional description for tests kselftest/alsa: pcm - Provide descriptions for the default tests kselftest/alsa: pcm - Add more coverage by default
tools/testing/selftests/alsa/Makefile | 2 +- tools/testing/selftests/alsa/alsa-local.h | 3 + tools/testing/selftests/alsa/conf.c | 26 ++- .../alsa/conf.d/Lenovo_ThinkPad_P1_Gen2.conf | 43 +++-- tools/testing/selftests/alsa/pcm-test.c | 205 ++++++++++++++------- tools/testing/selftests/alsa/pcm-test.conf | 63 +++++++ 6 files changed, 250 insertions(+), 92 deletions(-) create mode 100644 tools/testing/selftests/alsa/pcm-test.conf