Re: [PATCHv4 net-next 1/4] net: add a common function to compute features from lowers devices

Tue, Oct 14, 2025 at 10:02:14AM +0200, liuhangbin@gmail.com wrote:

[..]

+#define VIRTUAL_DEV_VLAN_FEATURES (NETIF_F_HW_CSUM | NETIF_F_SG | \

I don't like the "virtual" naming. In the past, we always tried to avoid that for lower-upper devices like bond/team/bridge/others. Soft-device was the used term. Please let the "virtual" term for vitrualization, would that be possible?

How about "master_upper"? This is already widely used to refer to bond/team/bridge/other master soft devices.

MASTER_UPPER_DEV_VLAN_FEATURES?

[..]

+void netdev_compute_features_from_lowers(struct net_device *dev, bool update_header)

netdev_compute_master_upper_features?