Re: [PATCH v5 5/5] selftests/resctrl: Add non-contiguous CBMs CAT test

Hi Maciej,

On 2/11/2024 11:38 PM, Maciej Wieczor-Retman wrote:

Sure, I guess I could make the check 'if (bit_center < 3)' to also check if the full_cache_mask isn't too short for some reason (since later 2 is substracted from bit_center for the 'hole' bit shift).

Thank you.

Or would this need some comment as well (why exactly the '3' is there, maybe write something about about the minimal full_cache_mask length for this test)?

The use of "Or" and "as well" makes it unclear what you propose. I do think the check in addition to a comment will be helpful.

Thank you.

Reinette