On Tue, 12 Aug 2025 22:27:00 +0900 Sang-Heon Jeon ekffu200098@gmail.com wrote:
Hello, Alexandre
On Tue, Aug 12, 2025 at 9:32 PM Sang-Heon Jeon ekffu200098@gmail.com wrote:
Hello, Alexandre
On Tue, Aug 12, 2025 at 5:13 PM Alexandre Ghiti alexghiti@rivosinc.com wrote:
_common.sh was recently introduced but is not installed and then triggers an error when trying to run the damon selftests:
selftests: damon: sysfs.sh ./sysfs.sh: line 4: _common.sh: No such file or directory
Install this file to avoid this error.
I tried to reproduce those error with my vm environment but I failed; with my workaround test method, it doesn't exist. If you're okay, could you please tell me line by line how you execute tests in what environment? I'm also struggling with the test environment, as well.
I succeeded to reproduce and also check that this patch removes those errors.
Fixes: 511914506d19 ("selftests/damon: introduce _common.sh to host shared function") Signed-off-by: Alexandre Ghiti alexghiti@rivosinc.com
Tested-by: Sang-Heon Jeon ekffu200098@gmail.com
Thank you, Sang-Heon :)
[...]
base-commit: 2754d549af31f8f029f02d02cd8e574676229b3d
Does this commit exist in `mm-new` or `damon-next`? I failed to setup the same base-commit environment.
However, I'm still not sure that this patch is in the correct baseline. maybe it will not cause any problems with the merge though... but I'm not sure. So I didn't add a reviewed-by tag.
I think unclear baseline of a patch shouldn't be a blocker of Reviewed-by tags. Since most DAMON patches are recommended to use mm-new[1], as long as the patch can cleanly applied on latest mm-new and you don't see anything wrong, I think you can assume it is based on mm-new.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#s...
Thanks, SJ
[...]