On Mon, Apr 28, 2025 at 11:21:43AM -0700, Nicolin Chen wrote:
On Mon, Apr 28, 2025 at 05:50:28PM +0000, Pranjal Shrivastava wrote:
On Fri, Apr 25, 2025 at 10:57:59PM -0700, Nicolin Chen wrote:
Similar to the iommu_copy_struct_from_user helper receiving data from the user space, add an iommu_copy_struct_to_user helper to report output data back to the user space data pointer.
Reviewed-by: Jason Gunthorpe jgg@nvidia.com Signed-off-by: Nicolin Chen nicolinc@nvidia.com
include/linux/iommu.h | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h index ba7add27e9a0..634ff647888d 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -562,6 +562,46 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size, return 0; } +/**
- __iommu_copy_struct_to_user - Report iommu driver specific user space data
- @dst_data: Pointer to a struct iommu_user_data for user space data location
- @src_data: Pointer to an iommu driver specific user data that is defined in
include/uapi/linux/iommufd.h
- @data_type: The data type of the @dst_data. Must match with @src_data.type
^
Nit: Must match with @dst_data type.
Oh, that's a copy-n-paste mistake. It should be:
- @data_type: The data type of the @src_data. Must match with @dst_data.type
Ack, yes that's what I meant!
Thanks! Nicolin
Thanks, Praan