Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline

On Sun, Mar 10, 2024 at 4:25 AM Miguel Ojeda miguel.ojeda.sandonis@gmail.com wrote:

On Sun, Mar 10, 2024 at 3:06 AM Ian Rogers irogers@google.com wrote:

...

[1] https://clang.llvm.org/docs/AttributeReference.html#noinline Reported-by: Christopher Di Bella cjdb@google.com

Out of curiosity, was this due to the `[[gnu::noinline]]` or similar in e.g. `src/string/memset_explicit.h`?

Yes, and in src/__support/threads/linux/thread.cpp's definition of start_thread().

Thanks for the patch!

Acked-by: Nick Desaulniers ndesaulniers@google.com