On Fri, 16 Aug 2024 17:32:39 +0100 Mark Brown broonie@kernel.org wrote:
On Fri, Aug 16, 2024 at 04:32:50PM +0100, Andre Przywara wrote:
When printing the value of a pointer, we should not use an integer format specifier, but the dedicated "%p" instead.
Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory")
This is another one where calling it a fix seems like it's pushing it, it's a modernisation rather than a correctness thing.
Well, I get compiler warnings, so I thought "fix" would be adequate. But in general this confusion between pointers and integers sounds not good, and not using %p looks like a genuine bug to me (though it's admittedly working fine (TM) for now).
Otherwise
Reviewed-by: Mark Brown broonie@kernel.org
Thanks for that!
Cheers, Andre