Re: [PATCHv2 net-next] selftests: net: move wait_local_port_listen to lib.sh

Hi Hangbin,

On 26/05/2025 03:46, Hangbin Liu wrote:

The function wait_local_port_listen() is the only function defined in net_helper.sh. Since some tests source both lib.sh and net_helper.sh, we can simplify the setup by moving wait_local_port_listen() to lib.sh.

With this change, net_helper.sh becomes redundant and can be removed.

Signed-off-by: Hangbin Liu liuhangbin@gmail.com

v2: remove net_helper in selftests/drivers (Matthieu Baerts)

Thank you for the update!

The new version looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) matttbe@kernel.org

Cheers, Matt