Hi Alexandre,
Thank you for looking at the rtc patch. I saw you Acked the [PATCH 2/2], not sure when could we see the patch in kernel master or next branch ?
Thank you, Joseph.
On 2024/6/21 3:37 AM, Alexandre Belloni wrote:
On 23/05/2024 18:38:07-0700, Joseph Jang wrote:
The rtctest requires the read permission on /dev/rtc0. The rtctest will be skipped if the /dev/rtc0 is not readable.
Reviewed-by: Koba Ko kobak@nvidia.com Reviewed-by: Matthew R. Ochs mochs@nvidia.com Signed-off-by: Joseph Jang jjang@nvidia.com
Acked-by: Alexandre Belloni alexandre.belloni@bootlin.com
tools/testing/selftests/rtc/rtctest.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c index 2b12497eb30d..d104f5326cf4 100644 --- a/tools/testing/selftests/rtc/rtctest.c +++ b/tools/testing/selftests/rtc/rtctest.c @@ -483,6 +483,8 @@ __constructor_order_last(void) int main(int argc, char **argv) {
- int ret = -1;
- switch (argc) { case 2: rtc_file = argv[1];
@@ -494,5 +496,12 @@ int main(int argc, char **argv) return 1; }
- return test_harness_run(argc, argv);
- /* Run the test if rtc_file is accessible */
- if (access(rtc_file, R_OK) == 0)
ret = test_harness_run(argc, argv);- else
ksft_exit_skip("[SKIP]: Cannot access rtc file %s - Exiting\n",rtc_file);- return ret; }
-- 2.34.1