On Fri, Oct 30, 2020 at 12:23 AM David Gow davidgow@google.com wrote:
On Fri, Oct 30, 2020 at 2:17 PM Daniel Latypov dlatypov@google.com wrote:
Currently --raw_output means nothing gets shown. Why? Because `raw_output()` has a `yield` and therefore is a generator, which means it only executes when you ask it for a value.
Given no one actually is using it as a generator (checked via the added type annotation), drop the yield so we actually print the output.
Also strip off the trailing \n (and any other whitespace) to avoid [<601d6d3a>] ? printk+0x0/0x9b
[<601e5058>] ? kernel_init+0x23/0x14b
[<600170d2>] ? new_thread_handler+0x82/0xc0 making the output unreadable.
Signed-off-by: Daniel Latypov dlatypov@google.com
The bug where --raw_output doesn't show anything is already fixed[1], but it does still show the extra newlines.
I'm not sure how I missed that, sorry for the noise.
Maybe it's worth making just the newline fix, and rolling it into the other patch[2] handling newlines?
Sounds good.
Cheers, -- David