On 25/09/2019 20:36, shuah wrote:
On 9/25/19 7:24 AM, Cristian Marussi wrote:
Let the user specify an optional TARGETS skiplist through the new optional SKIP_TARGETS Makefile variable.
It is easier to skip at will a reduced and well defined list of possibly problematic targets with SKIP_TARGETS then to provide a partially stripped down list of good targets using the usual TARGETS variable.
Signed-off-by: Cristian Marussi cristian.marussi@arm.com
tools/testing/selftests/Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 25b43a8c2b15..103936faa46d 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -132,6 +132,10 @@ else ARCH=$(ARCH) -C $(top_srcdir) headers_install endif +# User can optionally provide a TARGETS skiplist. +SKIP_TARGETS ?= +TARGETS := $(filter-out $(SKIP_TARGETS), $(TARGETS))
- all: khdr @for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \
Thanks for doing this. This looks good to me. Would you like to update the documentation file?
Thanks for the review Shuah, I'll add doc and fixes in V2 with a proper cover letter
Thanks
Cristian
thanks, -- Shuah