On Thu, 29 Sep 2022 18:37:09 +0200 netdev@kapio-technology.com wrote:
On 2022-09-29 18:10, Jakub Kicinski wrote:
On Wed, 28 Sep 2022 17:02:47 +0200 Hans Schultz wrote:
From: "Hans J. Schultz" netdev@kapio-technology.com
This patch set extends the locked port feature for devices that are behind a locked port, but do not have the ability to authorize themselves as a supplicant using IEEE 802.1X. Such devices can be printers, meters or anything related to fixed installations. Instead of 802.1X authorization, devices can get access based on their MAC addresses being whitelisted.
Try a allmodconfig build on latest net-next, seems broken.
I have all different switch drivers enabled and I see no compile warnings or errors.
Just do what I told you - rebase on net-next, allmodconfig.
I guess I will get a robot update if that is the case but please be specific as to what does not build.
The maintainers simply don't have time to hold everyone by the hand. Sometimes I wish it was still okay to yell at people who post code which does not build. Oh well.
../drivers/net/dsa/qca/qca8k-common.c:810:5: error: conflicting types for ‘qca8k_port_fdb_del’ int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/dsa/qca/qca8k-common.c:13: ../drivers/net/dsa/qca/qca8k.h:483:5: note: previous declaration of ‘qca8k_port_fdb_del’ was here int qca8k_port_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~~~~ ../drivers/net/dsa/qca/qca8k-common.c: In function ‘qca8k_port_fdb_del’: ../drivers/net/dsa/qca/qca8k-common.c:818:6: error: ‘fdb_flags’ undeclared (first use in this function); did you mean ‘tsq_flags’? if (fdb_flags) ^~~~~~~~~ tsq_flags ../drivers/net/dsa/qca/qca8k-common.c:818:6: note: each undeclared identifier is reported only once for each function it appears in make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/qca/qca8k-common.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/qca] Error 2 make[4]: *** Waiting for unfinished jobs.... ../drivers/net/dsa/sja1105/sja1105_main.c: In function ‘sja1105_fast_age’: ../drivers/net/dsa/sja1105/sja1105_main.c:1941:61: error: incompatible type for argument 5 of ‘sja1105_fdb_del’ rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected ‘u16’ {aka ‘short unsigned int’} but argument is of type ‘struct dsa_db’ u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1941:8: error: too few arguments to function ‘sja1105_fdb_del’ rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c: In function ‘sja1105_mdb_del’: ../drivers/net/dsa/sja1105/sja1105_main.c:1962:56: error: incompatible type for argument 5 of ‘sja1105_fdb_del’ return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~ ../drivers/net/dsa/sja1105/sja1105_main.c:1831:11: note: expected ‘u16’ {aka ‘short unsigned int’} but argument is of type ‘struct dsa_db’ u16 fdb_flags, struct dsa_db db) ~~~~^~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1962:9: error: too few arguments to function ‘sja1105_fdb_del’ return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1829:12: note: declared here static int sja1105_fdb_del(struct dsa_switch *ds, int port, ^~~~~~~~~~~~~~~ ../drivers/net/dsa/sja1105/sja1105_main.c:1963:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: some warnings being treated as errors make[5]: *** [../scripts/Makefile.build:249: drivers/net/dsa/sja1105/sja1105_main.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [../scripts/Makefile.build:465: drivers/net/dsa/sja1105] Error 2 make[3]: *** [../scripts/Makefile.build:465: drivers/net/dsa] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [../scripts/Makefile.build:465: drivers/net] Error 2 make[1]: *** [/home/kicinski/linux/Makefile:1852: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:222: __sub-make] Error 2