Re: [PATCH 1/2] mm, memcg: cg2 memory{.swap,}.peak write handlers

Hi Tejun,

On Fri, Jul 26, 2024 at 4:22 PM Tejun Heo tj@kernel.org wrote:

Hello, David.

On Tue, Jul 23, 2024 at 07:31:48PM -0400, David Finkel wrote: ...

...

• A write of the string "reset" to this file resets it to the
  

• current memory usage for subsequent reads through the same
  

• file descriptor.
  

• Attempts to write any other non-empty string will return EINVAL
  

• (modulo leading and trailing whitespace).
  

Let's just please do any write. We don't want to add complex write semantics to these files. Writing anything to reset these files is an established pattern and I don't think we gain anything by making this more complicated.

I still think something more limited is right here, but it seems that there's consensus that accepting all non-empty writes is the right option here, so I've removed the check. The next patchset will accept any (non-empty) write.

Thanks.

-- tejun

Thanks,