Re: [PATCH net-next 1/8] netdevsim: add more hw_features

On Thu, Nov 07, 2024 at 12:13:27AM +0100, Sabrina Dubroca wrote:

netdevsim currently only set HW_TC in its hw_features, but other features should also be present to better reflect the behavior of real HW.

In my macsec offload testing, this ends up as HW_CSUM being missing from hw_features, so it doesn't stick in wanted_features when offload is turned off. Then HW_CSUM (and thus TSO, thanks to netdev_fix_features) is not automatically turned back on when offload is re-enabled.

Signed-off-by: Sabrina Dubroca sd@queasysnail.net

Reviewed-by: Simon Horman horms@kernel.org