Re: [PATCH v2 5/5] kunit: make kunit_kfree(NULL) a no-op to match kfree()

On Fri, Jul 22, 2022 at 1:15 PM Daniel Latypov dlatypov@google.com wrote:

The real kfree() function will silently return when given a NULL. So a user might reasonably think they can write the following code: char *buffer = NULL; if (param->use_buffer) buffer = kunit_kzalloc(test, 10, GFP_KERNEL); ... kunit_kfree(test, buffer);

As-is, kunit_kfree() will mark the test as FAILED when buffer is NULL. (And in earlier times, it would segfault).

Let's match the semantics of kfree().

Suggested-by: David Gow davidgow@google.com Signed-off-by: Daniel Latypov dlatypov@google.com

Reviewed-by: Brendan Higgins brendanhiggins@google.com