Re: [PATCH v6 1/6] selftests/resctrl: Kill child process before parent process terminates if SIGTERM is received

On Fri, Mar 18, 2022 at 04:58:02PM +0900, Shaopeng Tan wrote:

In kselftest framework, a sub test is run using the timeout utility

s/is run/runs/

and it will send SIGTERM to the test upon timeout.

In resctrl_tests, a child process is created by fork() to run benchmark but SIGTERM is not set in sigaction(). If SIGTERM signal is received, the parent process will be killed, but the child process still exists.

kill child process before parent process terminates

s/kill/Kill the/ add "the" before "parent"

if SIGTERM signal is received.

Reviewed-by: Shuah Khan skhan@linuxfoundation.org Reviewed-by: Reinette Chatre reinette.chatre@intel.com Signed-off-by: Shaopeng Tan tan.shaopeng@jp.fujitsu.com

---

tools/testing/selftests/resctrl/resctrl_val.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c index 95224345c78e..b32b96356ec7 100644 --- a/tools/testing/selftests/resctrl/resctrl_val.c +++ b/tools/testing/selftests/resctrl/resctrl_val.c @@ -678,6 +678,7 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param) sigemptyset(&sigact.sa_mask); sigact.sa_flags = SA_SIGINFO; if (sigaction(SIGINT, &sigact, NULL) ||

•    sigaction(SIGTERM, &sigact, NULL) ||
   sigaction(SIGHUP, &sigact, NULL)) {
  

  perror("# sigaction"); ret = errno;

-- 2.27.0

Please fix the typos.

Reviewed-by: Fenghua Yu fenghua.yu@intel.com

Thanks.

-Fenghua