On 10/28/20 1:36 AM, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
On Tue, 2020-10-27 at 14:08 -0600, Shuah Khan wrote:
@@ -73,8 +80,8 @@ int main(int argc, char **argv) { aperf = new_aperf-old_aperf; mperf = new_mperf-old_mperf;
- start = before.time*1000 + before.millitm;
- finish = after.time*1000 + after.millitm;
- start = before.tv_sec*1000 + before.tv_nsec/1000000L;
- finish = after.tv_sec*1000 + after.tv_nsec/1000000L;
Why not use timespec dNSEC_PER_MSEC define from include/vdso/time64.h?
Hi,
If the define was available in the UAPI headers, then certainly would make sense to use it. But I would not mess with the kernel internal headers here.
Suggested the wrong file while looking up the define. I was thinking linux/time64.h
However it isn't part of headers_install, so can't use that one.
Considering the number of places NSEC_PER_MSEC is hard coded and defined in headers e.g: tools/include/linux/time64.h, probably should be included in timespec block in time.h
Not something to worry about for this patch. Please add a NSEC_PER_MSEC define for now in this file.
thanks, -- Shuah