Re: [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure

On 05/29/2018 10:56 PM, Prashant Bhole wrote:

Test failures are not identified because exit code of RX/TX threads is not checked. Also threads are not returning correct exit code.

• Return exit code from threads depending on test execution status
• In main thread, check the exit code of RX/TX threads
• Skip error checking for corked tests as they are expected to timeout

Fixes: 16962b2404ac ("bpf: sockmap, add selftests") Signed-off-by: Prashant Bhole bhole_prashant_q7@lab.ntt.co.jp

---

tools/testing/selftests/bpf/test_sockmap.c | 25 ++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-)

Looks good. Thanks.

Acked-by: John Fastabend john.fastabend@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html