On 12/5/18 3:54 PM, Brendan Higgins wrote:
On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand frowand.list@gmail.com wrote:
Hi Brendan,
On 11/28/18 11:36 AM, Brendan Higgins wrote:
Split out a couple of test cases that these features in base.c from the unittest.c monolith. The intention is that we will eventually split out all test cases and group them together based on what portion of device tree they test.
Why does splitting this file apart improve the implementation?
This is in preparation for patch 19/19 and other hypothetical future patches where test cases are split up and grouped together by what portion of DT they test (for example the parsing tests and the platform/device tests would probably go separate files as well). This patch by itself does not do anything useful, but I figured it made patch 19/19 (and, if you like what I am doing, subsequent patches) easier to review.
I do not see any value in splitting the devicetree tests into multiple files.
Please help me understand what the benefits of such a split are.
Thanks,
Frank