On Tue, Apr 30, 2024, Chao Gao wrote:
On Thu, Feb 08, 2024 at 01:26:34AM +0800, Xin Li wrote:
Refuse to virtualize FRED if FRED consistency checks fail.
After reading this, I realize some consistency checks are missing in setup_vmcs_config(). Actually Sean requested some infrastructure for vmcs_entry_exit_pairs to deal with secondary_vmexit_ctrl.
Yeah, this belongs in setup_vmcs_config(), e.g. to guarantee that discrepancies between CPUs are detected. I would also strongly prefer this be squashed with the patch(es) that introduce recognition of the FRED fields, if only so that we can avoid "consistency checks" in the shortlog (I thought this patch was going to disable FRED if a VM-Enter consistency check failed, which would be... interesting).