On 7/10/24 11:04, Adrian Moreno wrote:
There are a couple of places where the test script "sleep"s to wait for some external condition to be met.
This is error prone, specially in slow systems (identified in CI by "KSFT_MACHINE_SLOW=yes").
To fix this, add a "ovs_wait" function that tries to execute a command a few times until it succeeds. The timeout used is set to 5s for "normal" systems and doubled if a slow CI machine is detected.
This should make the following work:
$ vng --build \ --config tools/testing/selftests/net/config \ --config kernel/configs/debug.config
$ vng --run . --user root -- "make -C tools/testing/selftests/ \ KSFT_MACHINE_SLOW=yes TARGETS=net/openvswitch run_tests"
Signed-off-by: Adrian Moreno amorenoz@redhat.com
.../selftests/net/openvswitch/openvswitch.sh | 45 +++++++++++++++---- .../selftests/net/openvswitch/ovs-dpctl.py | 1 + 2 files changed, 38 insertions(+), 8 deletions(-)
Seem like we don't have a signal from CI for some reason yet, but I tested this locally and it seem to work fine. Either way it's a better way of doing things than sleep'n'hope.
Reviewed-by: Ilya Maximets i.maximets@ovn.org