On Tue, 18 Jul 2023 at 18:50, Miguel Ojeda miguel.ojeda.sandonis@gmail.com wrote:
On Tue, Jul 18, 2023 at 10:17 AM David Gow davidgow@google.com wrote:
This is looking good and working well here.
One super-minor thought below (the generated C file seems to be using 4-space indentation, not tabs), but it's not something that worries me enough to hold the patch up if there are no other issues.
Good eye! Of course, please feel free to change it when applying (though from a quick grep I don't see "[ ... ]" comments in commits in the KUnit tree). I am also happy to send a v3.
We merged this as-is, and I've sent out a fixup patch here: https://lore.kernel.org/linux-kselftest/20230720062939.2411889-1-davidgow@go...
I wasn't able to find any issues with changing the indentation, but let me know if there's some tool which complains about seeing tabs in .rs files we need to worry about.
Cheers, -- David