Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module

On Sun, 16 Mar 2025 16:39:17 +0100 chia-yu.chang@nokia-bell-labs.com wrote:

+static int try_get_percentage(int *val, const char *arg, int base) +{

• long res;
• char *ptr;
• if (!arg || !*arg)

• return -1;
  

• res = strtol(arg, &ptr, base);
• if (!ptr || ptr == arg || (*ptr && strcmp(ptr, "%")))

• return -1;
  

• if (res == ULONG_MAX && errno == ERANGE)

• return -1;
  

• if (res < 0 || res > 100)

• return -1;
  

• *val = res;
• return 0;

+}

I wonder if dualpi2 and netem could share some code on handling scaled percentage values.