Re: [PATCH v4 05/23] iommufd/driver: Let iommufd_viommu_alloc helper save ictx to viommu->ictx

On Fri, May 16, 2025 at 01:56:26PM -0700, Nicolin Chen wrote:

...

You don't need to move this unless you are using inlines. Just use a forward declaration.

Since we forward ucmd now, ictx is in the ucmd so we need this structure for:

• if (!IS_ERR(ret))                                              \
  

• if (!IS_ERR(ret)) {                                            \
  ret->member.ops = viommu_ops;                          \
  

• 	ret->member.ictx = ucmd->ictx;                         \
  

• }                                                              \
  

De-inline more of that function probably..

Also seem my other remarks about not storing ictx so much..

Jason