Re: [PATCH net 03/10] netlink: specs: ethtool: replace underscores with dashes in names

Le Tue, 24 Jun 2025 14:09:55 -0700, Jakub Kicinski kuba@kernel.org a écrit :

We're trying to add a strict regexp for the name format in the spec. Underscores will not be allowed, dashes should be used instead. This makes no difference to C (codegen replaces special chars in names) but gives more uniform naming in Python.

Reviewed-by: Kory Maincent kory.maincent@bootlin.com

Thank you!

Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash") Fixes: 46fb3ba95b93 ("ethtool: Add an interface for flashing transceiver modules' firmware")

Why do you use fixes tag? You are not fixing something broken but standardizing the python naming.

Regards,