Re: [PATCH v2 1/3] mm/huge_memory: add new_order and offset to split_huge_pages*() pr_debug.

On 2025/8/9 03:01, Zi Yan wrote:

They are useful information for debugging split huge page tests.

Signed-off-by: Zi Yan ziy@nvidia.com

LGTM. Reviewed-by: Baolin Wang baolin.wang@linux.alibaba.com

mm/huge_memory.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2b4ea5a2ce7d..ebf875928bac 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -4327,8 +4327,8 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, goto out; }

• pr_debug("Split huge pages in pid: %d, vaddr: [0x%lx - 0x%lx]\n",

•  pid, vaddr_start, vaddr_end);
  

• pr_debug("Split huge pages in pid: %d, vaddr: [0x%lx - 0x%lx], new_order: %u, in_folio_offset: %ld\n",

•  pid, vaddr_start, vaddr_end, new_order, in_folio_offset);
  

mmap_read_lock(mm); /* @@ -4438,8 +4438,8 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start, if (IS_ERR(candidate)) goto out;

• pr_debug("split file-backed THPs in file: %s, page offset: [0x%lx - 0x%lx]\n",

•  file_path, off_start, off_end);
  

• pr_debug("split file-backed THPs in file: %s, page offset: [0x%lx - 0x%lx], new_order: %u, in_folio_offset: %ld\n",

•  file_path, off_start, off_end, new_order, in_folio_offset);
  

mapping = candidate->f_mapping; min_order = mapping_min_folio_order(mapping);