Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

On Mon, Nov 18, 2024 at 1:49 AM Christoph Hellwig hch@infradead.org wrote:

On Sat, Nov 16, 2024 at 05:59:18PM +0000, Pasha Tatashin wrote:

...

  } while (start = next, start < end);
  return err;

} +EXPORT_SYMBOL_GPL(walk_page_range);

Umm, no. We really should not expose all these page table detail to modules.

...

+EXPORT_SYMBOL_GPL(walk_page_range_kernel);

Even more so here.

I will remove these exports in the next version, as I am going to convert Page Detective to be part of core mm instead of misc device.

Thanks, Pasha