Re: [PATCH net-next v4 4/6] net: bridge: Add netlink knobs for number / max learned FDB entries

On Wed, Sep 20, 2023 at 01:50:32PM +0300, Nikolay Aleksandrov wrote:

On 9/19/23 11:12, Johannes Nixdorf wrote:

...

[...] diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 505683ef9a26..f5d49a05e61b 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -1267,6 +1267,8 @@ static const struct nla_policy br_policy[IFLA_BR_MAX + 1] = { [IFLA_BR_VLAN_STATS_PER_PORT] = { .type = NLA_U8 }, [IFLA_BR_MULTI_BOOLOPT] = NLA_POLICY_EXACT_LEN(sizeof(struct br_boolopt_multi)),

• [IFLA_BR_FDB_N_LEARNED] = { .type = NLA_U32 },

hmm? I thought this one was RO.

You are right. I set this to NLA_REJECT locally for v5 now, analogously to how IFLA_BRPORT_MCAST_N_GROUPS is specified.

...

[...]