[AMD Official Use Only - General]
Hi Peter:
-----Original Message----- From: Peter Zijlstra peterz@infradead.org Sent: Sunday, September 10, 2023 1:40 AM To: Meng, Li (Jassmine) Li.Meng@amd.com Cc: Rafael J . Wysocki rafael.j.wysocki@intel.com; Huang, Ray Ray.Huang@amd.com; linux-pm@vger.kernel.org; linux- kernel@vger.kernel.org; x86@kernel.org; linux-acpi@vger.kernel.org; Shuah Khan skhan@linuxfoundation.org; linux-kselftest@vger.kernel.org; Fontenot, Nathan Nathan.Fontenot@amd.com; Sharma, Deepak Deepak.Sharma@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Limonciello, Mario Mario.Limonciello@amd.com; Huang, Shimmer Shimmer.Huang@amd.com; Yuan, Perry Perry.Yuan@amd.com; Du, Xiaojian Xiaojian.Du@amd.com; Viresh Kumar viresh.kumar@linaro.org; Borislav Petkov bp@alien8.de Subject: Re: [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting.
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On Fri, Sep 08, 2023 at 03:46:49PM +0800, Meng Li wrote:
+static void amd_pstate_init_prefcore(void) {
int cpu, ret;u64 highest_perf;if (!prefcore)return;for_each_online_cpu(cpu) {ret = amd_pstate_get_highest_perf(cpu, &highest_perf);if (ret)break;sched_set_itmt_core_prio(highest_perf, cpu);/* check if CPPC preferred core feature is enabled*/if (highest_perf == AMD_PSTATE_MAX_CPPC_PERF) {pr_debug("AMD CPPC preferred core is unsupported!\n");hw_prefcore = false;prefcore = false;return;}}/** This code can be run during CPU online under the* CPU hotplug locks, so sched_set_amd_prefcore_support()* cannot be called from here. Queue up a work item* to invoke it.*/schedule_work(&sched_prefcore_work);+}
Brilliant, repost without addressing prior feedback.. :-(
[Meng, Li (Jassmine)] I am very sorry that I did not receive your V5 review comments before sending V6 patches. However, thank you very much for your review. I will solve them one by one in the future V7 patches. Thank you very much!