Re: [PATCH v12 1/3] x86/tdx: Add TDX Guest attestation interface driver

Hi Dave/Greg,

On 9/7/22 10:31 PM, Greg Kroah-Hartman wrote:

On Wed, Sep 07, 2022 at 05:27:20PM -0700, Kuppuswamy Sathyanarayanan wrote:

...

• /*

• * Per TDX Module 1.0 specification, section titled
  

• * "TDG.MR.REPORT", REPORTDATA length is fixed as
  

• * TDX_REPORTDATA_LEN, TDREPORT length is fixed as
  

• * TDX_REPORT_LEN, and TDREPORT subtype is fixed as
  

• * 0. Also check for valid user pointers.
  

• */
  

• if (!req.reportdata || !req.tdreport || req.subtype ||

• req.rpd_len != TDX_REPORTDATA_LEN ||
  

• req.tdr_len != TDX_REPORT_LEN)
  

• return -EINVAL;
  

You never verify that your reserved[7] fields are actually set to 0, which means you can never use them in the future :(

Please fix that up, thanks.

Would you prefer a new posting (v12.1 or v13) with this change, or do you want to continue the review in the same version?

greg k-h