On 07-Jun-20 21:25, Florian Fainelli wrote:
On 6/7/2020 7:59 AM, Amit Cohen wrote:
Implement .get_down_ext_state() as part of ethtool_ops. Query link down reason from PDDR register and convert it to ethtool ext_state.
In case that more information than common ext_state is provided, fill ext_substate also with the appropriate value.
Signed-off-by: Amit Cohen amitc@mellanox.com Reviewed-by: Petr Machata petrm@mellanox.com Reviewed-by: Jiri Pirko jiri@mellanox.com
Is the firmware smart enough to report ETHTOOL_EXT_SUBSTATE_LT_KR_FRAME_LOCK_NOT_ACQUIRED only when using a *KR link mode for instance, or do you need to sanitize that against the supported/advertised mode?
This reason can appear with copper cable or backplane. At the moment it is only supported with AN and PD modes (not Force mode).