Re: [PATCH v1 2/2] selftests: gpio: gpio-sim: Use same variable name for sysfs pathname

On Tue, Apr 11, 2023 at 7:15 PM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:

SYSFS_PATH can be used locally and globally, especially that has the same content.

Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com

tools/testing/selftests/gpio/gpio-sim.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh index fa2ce2b9dd5f..6fb66a687f17 100755 --- a/tools/testing/selftests/gpio/gpio-sim.sh +++ b/tools/testing/selftests/gpio/gpio-sim.sh @@ -152,9 +152,9 @@ sysfs_set_pull() { local PULL=$4 local DEVNAME=`configfs_dev_name $DEV` local CHIPNAME=`configfs_chip_name $DEV $BANK`

•   local SYSFSPATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/pull"
  

•   local SYSFS_PATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/pull"
  
  

•   echo $PULL > $SYSFSPATH || fail "Unable to set line pull in sysfs"
  

•   echo $PULL > $SYSFS_PATH || fail "Unable to set line pull in sysfs"
  

}

# Load the gpio-sim module. This will pull in configfs if needed too.

2.40.0.1.gaa8946217a0b

Applied, thanks!

Bart