On 5/29/20 2:37 PM, Seth Forshee wrote:
On Wed, Mar 04, 2020 at 04:20:09PM -0600, Seth Forshee wrote:
Test cases which use echo to write strings containing backslashes fail with some shells, as echo's treatment of backslashes in strings varies between shell implementations. Use printf instead, as it should behave consistently across different shells. This requires adjustments to the strings to escape \ and % characters. ftrace_errlog_check() must also re-escape these characters after processing them to remove ^ characters.
Signed-off-by: Seth Forshee seth.forshee@canonical.com
Ping. Someone just asked me about this patch, and I noticed that it hasn't been applied or received any feedback.
I pulled in this patch from Masami:
selftests/ftrace: Use printf for backslash included command https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/co...
Looks like a duplicate.
Seth, Is your patch still needed?
+ Steve and Masami
thanks, -- Shuah