Re: [PATCH 3/4] selftests/sgx: Ensure enclave data available during debug print

On 1/28/22 10:23, Reinette Chatre wrote:

In support of debugging the SGX tests print details from the enclave and its memory mappings if any failure is encountered during enclave loading.

When a failure is encountered no data is printed because the printing of the data is preceded by cleanup of the data.

Move the data cleanup after the data print.

Isn't it worse than that?

err:

• encl_delete(encl);
• for (i = 0; i < encl->nr_segments; i++) { seg = &encl->segment_tbl[i];

encl_delete() does:

free(encl->segment_tbl);

but doesn't zero encl->nr_segments from what I can see. That seems like a use-after-free.

Seems like we need to really run the selftest under valgrind.